fix(projections.html) Fixes the projections swapping and serialization for store #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-NRCan
force-pushed
the
fix-projections
branch
3 times, most recently
from
d2fa1cc to
ef2dc8b
Compare
Alex-NRCan
force-pushed
the
fix-projections
branch
5 times, most recently
from
cc63be0 to
c65d579
Compare
Alex-NRCan
changed the title
Alex-NRCan
force-pushed
the
fix-projections
branch
from
c65d579 to
bda4cc1
Compare
Alex-NRCan
commented
Feb 29, 2024
There was a problem hiding this comment.
Reviewed 2 of 6 files at r1, 5 of 5 files at r2, 1 of 2 files at r4, 6 of 6 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jolevesq)
Projections working Some comments Removed an old eslint Rush update --removed actually Getting rid of 2 eslint warnings Removed dead code Removed comment about renaming the config types/classes
Alex-NRCan
force-pushed
the
fix-projections
branch
from
bda4cc1 to
686f34b
Compare
Alex-NRCan
commented
Feb 29, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status:
jolevesq
merged commit 3c155ba
into
Canadian-Geospatial-Platform:develop
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the projections swapping
New serialization principles inside the LayerConfig classes, for the store.
Projections working
Some comments
Removed an old eslint line disabled
Rush update
Getting rid of 2 eslint warnings elsewhere
Removed dead code after changes in another PR
Removed comment about renaming the config types/classes, it's already in progress in other PR
Fixes #1728
Type of change
How Has This Been Tested?
Hosted as of Feb 29 8h15 here: https://alex-nrcan.github.io/geoview/projections.html#HPRJ3
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is